test: Remove support for Node 18 #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1454 +/- ##
=======================================
Coverage 89.23% 89.23%
=======================================
Files 315 315
Lines 5545 5545
Branches 1372 1372
=======================================
Hits 4948 4948
- Misses 581 582 +1
+ Partials 16 15 -1 ☔ View full report in Codecov by Sentry. |
|
Note: per openedx/public-engineering#280 we can only merge this after Sumac is cut. |
|
@BilalQamar95 Note: before merging this, we need to update it to not use frontend-app-learning/.github/workflows/validate.yml Lines 24 to 26 in d47433e frontend-app-learning/.github/workflows/validate.yml Lines 36 to 38 in d47433e |
…o bilalqamar95/node20-upgrade-3
bradenmacdonald
approved these changes
Oct 29, 2024
brian-smith-tcril
approved these changes
Oct 31, 2024
Closed
KristinAoki
pushed a commit
that referenced
this pull request
Nov 1, 2024
* test: Remove support for Node 18 * chore: update code coverage artifact naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Completed upgrade to Node 20 by removing the Node 18 CI check and using
.nvmrcfor version to use.See the tracking issue for further information.